Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PriorityScoreFilter: throw error and stop or change design? #340

Open
julesjacobsen opened this issue Jun 12, 2019 · 0 comments
Open

PriorityScoreFilter: throw error and stop or change design? #340

julesjacobsen opened this issue Jun 12, 2019 · 0 comments

Comments

@julesjacobsen
Copy link
Contributor

julesjacobsen commented Jun 12, 2019

Currently supplying these:

  - hiPhivePrioritiser: {runParams: human}
  - priorityScoreFilter: {minPriorityScore: 0.501, priorityType: PHENIX_PRIORITY}

only results in a INFO (with a WARNING!):

INFO 11352 --- [           main] o.m.e.core.analysis.AnalysisStepChecker  : WARNING: Removing PriorityScoreFilter{priorityType=PHENIX_PRIORITY, minPriorityScore=0.501} as the corresponding Prioritiser is not present. AnalysisSteps have been changed.

This leads to incorrect results and likely confusion on the part of the user. Ideally the input parameters should not allow this to happen - i.e. the PriorityScoreFilter should only accept a minPriorityScore and it will filter the results accordingly. Like so:

  - hiPhivePrioritiser: {runParams: human}
  - priorityScoreFilter: {minPriorityScore: 0.501}

The requirement for the priorityType comes in part from the OmimPrioritiser not really behaving like other Prioritisers. It is really an inheritance mode score modifier.

This is related to #337 and #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant