Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen changes update queries #38

Open
exerro opened this issue Feb 11, 2017 · 1 comment
Open

Screen changes update queries #38

exerro opened this issue Feb 11, 2017 · 1 comment
Labels

Comments

@exerro
Copy link
Owner

exerro commented Feb 11, 2017

If you give a Screen a width_transition and then update its width, it'll break after calling Application:child_value_changed( Screen ) which in turn calls QueryTracker:update( "child-changed", Screen ) which in turn will test the query function on the Screen which can break if the query is a tag query.

Solution: make Screen extend Sheet and define custom behaviour. They're pretty similar anyway, and then it'll be easier to target them in dynamic values later on. This will allow giving Screens tags and IDs. Nifty, huh?

@exerro exerro added the bug label Feb 11, 2017
@exerro
Copy link
Owner Author

exerro commented Feb 16, 2017

As Screens don't have an x/y position and are actually pretty different to Sheets, they will simply implement the interface that gives Sheets the tag/ID behaviour. Should fix stuff, if a little hacky.

There may be more problems with referencing Screen values from dynamic values and queries, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant