-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix instructions for completion in Oh My Zsh #881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, so sorry I missed the original ping and made you wait for a month for feedback!
I have one question as the copy command looks surprising to me, but otherwise this is ready to go.
Ping 😄 |
Might be worth adding a note about clearing the completion cache (https://github.com/ohmyzsh/ohmyzsh/wiki/FAQ#i-have-enabled-a-completion-plugin-but-the-completion-doesnt-work). This had me tripped up for quite a while before I got it working. |
This works well and should be merged 👍 |
I didn't encounter any cache problems with a clean install, and there seems to be a note stating that the completion is now checking the plugin list on their wiki |
d505c47
to
48fe515
Compare
@Stigjb Could you please help me understand why does one of the checks fail? |
@allentiak I do not know why it failed, but it succeeded after updating the PR with the main branch |
I would merge, but I don't have the appropriate rights. Give it a day or so, we should hear something back. |
Thanks! |
Fixes exercism/exercism#5029
Also cf. #865
Changed oh-my-zsh to Oh My Zsh to match the style in the official repo