Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require gofmt on Travis build #761

Merged
merged 3 commits into from
Nov 9, 2018
Merged

Conversation

jdsutherland
Copy link
Contributor

@jdsutherland jdsutherland commented Nov 8, 2018

Closes #760

@jdsutherland jdsutherland force-pushed the travis-gofmt branch 3 times, most recently from fe4068b to 5cd3ab0 Compare November 8, 2018 04:01
@jdsutherland jdsutherland force-pushed the travis-gofmt branch 3 times, most recently from cd80fe7 to 6bb97c9 Compare November 8, 2018 04:22
#!/bin/bash

cd "$(dirname $0)"
if [ -n "$(go fmt ./...)" ]; then
Copy link
Contributor Author

@jdsutherland jdsutherland Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I yanked google/gopacket's approach.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sweet, thank you! 💙

#!/bin/bash

cd "$(dirname $0)"
if [ -n "$(go fmt ./...)" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@kytrinyx kytrinyx merged commit f3682f4 into exercism:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants