Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Travis versions #750

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Bump Travis versions #750

merged 1 commit into from
Oct 25, 2018

Conversation

HaraldNordgren
Copy link
Contributor

No description provided.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaraldNordgren thanks for updating the supported versions on travis. I left a comment requesting that we drop 1.9 from the matrix.

I'll open a subsequent PR to bump the minimum version in [CONTRIBUTING.md](https://github.com/exercism/cli/blob/master/CONTRIBUTING.md#dependencies} to 1.10.

.travis.yml Outdated
@@ -5,7 +5,8 @@ sudo: false
go:
- "1.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When updating supported versions on Travis we tend to drop support for the second oldest version (i.e 1.9).

Suggested change
- "1.9"

@HaraldNordgren
Copy link
Contributor Author

@nywilken I would rather test a wider array of Go versions to maintain backward compatibility as long as it is viable. Could you explain you reasoning a bit further? 🙂

@kytrinyx
Copy link
Member

@HaraldNordgren This only affects people contributing to the package, not people using the CLI. We find that overall Go developers upgrade within the year, and if they don't we feel it's ok if they get slower feedback by seeing failing tests in CI.

@HaraldNordgren HaraldNordgren force-pushed the master branch 2 times, most recently from 8f08728 to 74714a2 Compare October 22, 2018 21:52
@HaraldNordgren
Copy link
Contributor Author

@nywilken @kytrinyx Understood. I made sure to change CONTRIBUTING.md as well since the one change doesn't make much sense without the other, and vice versa.

@nywilken
Copy link
Contributor

@HaraldNordgren sorry for the slow response on this. Thank you for making the updates.

@nywilken nywilken merged commit ed6dc02 into exercism:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants