-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Travis versions #750
Bump Travis versions #750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaraldNordgren thanks for updating the supported versions on travis. I left a comment requesting that we drop 1.9 from the matrix.
I'll open a subsequent PR to bump the minimum version in [CONTRIBUTING.md](https://github.com/exercism/cli/blob/master/CONTRIBUTING.md#dependencies} to 1.10.
.travis.yml
Outdated
@@ -5,7 +5,8 @@ sudo: false | |||
go: | |||
- "1.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When updating supported versions on Travis we tend to drop support for the second oldest version (i.e 1.9).
- "1.9" |
@nywilken I would rather test a wider array of Go versions to maintain backward compatibility as long as it is viable. Could you explain you reasoning a bit further? 🙂 |
@HaraldNordgren This only affects people contributing to the package, not people using the CLI. We find that overall Go developers upgrade within the year, and if they don't we feel it's ok if they get slower feedback by seeing failing tests in CI. |
8f08728
to
74714a2
Compare
74714a2
to
374bb47
Compare
@HaraldNordgren sorry for the slow response on this. Thank you for making the updates. |
No description provided.