Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit only checks 400 when printing success (404 etc. unhandled) #790

Closed
jdsutherland opened this issue Jan 9, 2019 · 3 comments
Closed

Comments

@jdsutherland
Copy link
Contributor

jdsutherland commented Jan 9, 2019

Currently, submit only checks for 400 responses before printing a success message. 404s are silent and the resulting output misleadingly indicates that the submission was successful.

Mentioned in #770 (comment).

@iHiD
Copy link
Member

iHiD commented Jul 6, 2019

Hello @exercism/cli :)

This has come up a couple of times recently. It's been suggested that this commit never got released. If that's so, could we release it? Is there anything else blocking that?

Thanks :)

@kytrinyx
Copy link
Member

kytrinyx commented Jul 6, 2019

I'll do a release to day!

@iHiD
Copy link
Member

iHiD commented Jul 6, 2019

(cc @NobbZ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants