Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to configure line numbers via CodeMirror #38

Open
2 tasks
patrickmineault opened this issue Aug 28, 2021 · 2 comments
Open
2 tasks

Make it possible to configure line numbers via CodeMirror #38

patrickmineault opened this issue Aug 28, 2021 · 2 comments
Labels
blocked This is blocked until another issue is resolved documentation Improvements or additions to documentation enhancement New feature or request

Comments

@patrickmineault
Copy link

patrickmineault commented Aug 28, 2021

Description / Summary

CodeMirror supports showing line numbers through the lineNumbers option. This option appears to be set to false by default. It would be nice if we could enable this option from this Sphinx theme.

Value / benefit

When the code is run in a cell and it has an error, it references line numbers. It would be nice if those line numbers were visible in the editor.

Implementation details

I think this option could be forwarded from sphinx-thebe to mainland thebe, and then onwards to CodeMirror.

Tasks to complete

@patrickmineault patrickmineault added the enhancement New feature or request label Aug 28, 2021
@welcome
Copy link

welcome bot commented Aug 28, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@choldgraf
Copy link
Member

Hey - yep, this would indeed be useful. I think that it could be resolved by #17 (and one shot at implementing this here #25).

@choldgraf choldgraf changed the title lineNumbers configuration Make it possible to configure line numbers via CodeMirror Aug 28, 2021
@choldgraf choldgraf added documentation Improvements or additions to documentation blocked This is blocked until another issue is resolved labels Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This is blocked until another issue is resolved documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants