Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spaces in labels #28

Closed
choldgraf opened this issue Aug 23, 2021 · 1 comment · Fixed by #31
Closed

Support spaces in labels #28

choldgraf opened this issue Aug 23, 2021 · 1 comment · Fixed by #31
Labels
enhancement New feature or request

Comments

@choldgraf
Copy link
Member

choldgraf commented Aug 23, 2021

Describe the enhancement you'd like

It would be useful if it were possible to use spaces in labels, like so:

(my label)=
# My header

Ref for [](my label).

In executablebooks/meta#467 (comment) we discovered that, while reStructuredText supports spaces in labels, like .. _my label:, the MyST parser does not.

Benefit

This would be useful for people who are coming from the rST / Sphinx ecosystem, since this is already supported in rST. However it's probably not a huge number of people using labels this way because most seem to use - or _ for this kind of thing.

Implementation

The fix for this would probably somewhere around here:

def target(state: StateBlock, startLine: int, endLine: int, silent: bool):

@choldgraf choldgraf added the enhancement New feature or request label Aug 23, 2021
@welcome
Copy link

welcome bot commented Aug 23, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant