Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to exclude backported PRs #84

Open
3 tasks
minrk opened this issue Feb 27, 2023 · 0 comments
Open
3 tasks

ability to exclude backported PRs #84

minrk opened this issue Feb 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@minrk
Copy link
Contributor

minrk commented Feb 27, 2023

Context

In several of our projects, we backport fixes to a previous release while working on a major release in main - it would be useful to be able to exclude the backported PR so the change doesn't appear twice or give the misleading indication that a feature or bugfix originally made on the development branch for 4.0 was not also released in e.g. 3.1.

For example, in making the changelog for JupyterHub 4.0, I get in the enhancements:

when none of these should be included as changes in 4.0.

so each backported change is present twice, when what I want is for none of these 4 entries. (-b main excludes the backports, but I currently like to include them because it helps with the manual deletions of the duplicates!)

Proposal

A simple version would be to allow excluding on a specific label (or label pattern). Doing this by default might present problems, because the exclusions might be the opposite of what you want for the backport release. If you use backport-pr tools like mrmeeseeks (or manual backporting with a separate PR), though, this shouldn't be an issue because the change already appears twice as two separate PRs, and only the 'mainline' PR should be excluded, which would be the one with the label.

Tasks and updates

  • decide how to identify backport prs
  • decide what to do by default
  • implement exclusions (and options, if any)
@minrk minrk added the enhancement New feature or request label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant