Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace language-container deployer with the common implementation in python-extension-common #118

Closed
tkilias opened this issue May 23, 2024 · 0 comments · Fixed by #121
Closed
Assignees
Labels
refactoring Code improvement without behavior change

Comments

@tkilias
Copy link
Collaborator

tkilias commented May 23, 2024

We extracted a common implementation for the language-container deployer to the python-extension-common repo.
We need to replace the implementation with common by importing and configuring it.

Tasks:

  • language_container_deployer.py can be removed, because it is completely implemented in python-extension-common
  • language_container_deployer_cli.py can be removed, because it is completely implemented in python-extension-common
  • deploy.py needs its imports changed to python-extension-common
  • sme_language_container_deployer.py needs its imports changed to python-extension-common
  • We probably need a test, that at least checks, if the path defined sme_language_container_deployer.py work with deployer cli and SmeLanguageContainerDeployer
@tkilias tkilias added feature Product feature refactoring Code improvement without behavior change and removed feature Product feature labels May 23, 2024
@Shmuma Shmuma self-assigned this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
2 participants