New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect vs follow_redirect vs follow_redirects #1110

Open

inoas-nbw opened this issue Jan 13, 2025 · 0 comments

inoas-nbw commented Jan 13, 2025

req < 0.4.0 expects follow_redirects
req >= 0.4.0 expects redirect
hackney option may be follow_redirect

https://github.com/ex-aws/ex_aws/blob/v2.5.7/lib/ex_aws/request/req.ex#L39
https://github.com/ex-aws/ex_aws/blob/v2.5.8/lib/ex_aws/request/req.ex#L34
https://hexdocs.pm/req/0.3.12/Req.Steps.html#follow_redirects/1
https://hexdocs.pm/req/0.5.8/Req.Steps.html#redirect/1

=> as req is not stable and ex_aws does not specify req above 0.4, it should set both, follow_redirects and redirect.
also the current comment is missleading https://github.com/ex-aws/ex_aws/blob/v2.5.8/lib/ex_aws/request/req.ex#L34

inoas-nbw mentioned this issue

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment