Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path().build() default separator causes invalid path #2

Closed
gnbl opened this issue Jul 5, 2022 · 3 comments
Closed

Path().build() default separator causes invalid path #2

gnbl opened this issue Jul 5, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@gnbl
Copy link

gnbl commented Jul 5, 2022

Path.build() uses a comma , as default separator between commands, which apparently is invalid - at least Firefox does not render the resulting path, and https://svg-path-visualizer.netlify.app/ prints "Unexpected character "A" at index 9. Command cannot follow comma".

M 10 30, A 20 20 0 0 1 50 30, A 20 20 0 0 1 50 30, Q 90 60 50 90, Q 10 60 10 30, Z

from

https://github.com/evtn/soda/blob/lord/README.md?plain=1#L227

@evtn evtn added the bug Something isn't working label Jul 5, 2022
@evtn
Copy link
Owner

evtn commented Jul 5, 2022

Fixed in v0.1.8 (removed sep altogether, now " " is the only possible command separator in non-compact mode)

@evtn evtn closed this as completed Jul 5, 2022
@gnbl
Copy link
Author

gnbl commented Jul 5, 2022

That's not backwards compatible / breaks code using sep. I don't mind since that's only one line for me to change and I've just started using this lib.

@evtn
Copy link
Owner

evtn commented Jul 5, 2022

It kinda isn't backward-compatible, sure.
But as "," is invalid and the only other option is " ", there is no reason to leave sep there.
Also, as version is 0.x.y, public API should not be considered stable.

Although, maybe I should bump version to 1.x.y as module is pretty much complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants