Refactor syntax objects due to #117 #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rework `*Helper` objects to be traits & object in order to create `syntax.all`; note: this is breaking, because someone could have been importing implicit classes explicitly, but now they are not available;
t3hnar
suggested changes
Dec 10, 2021
| fiber <- faOf(started).start | ||
| _ <- started.get | ||
| fiber <- faOf(started).start | ||
| _ <- started.get |
There was a problem hiding this comment.
not sure this is nicer now :)
| object ParallelHelper { | ||
| object ParallelHelper extends ParallelSyntax | ||
|
|
||
| trait ParallelSyntax { |
There was a problem hiding this comment.
why not move all *Syntax classes into own files?
There was a problem hiding this comment.
also I propose to make alternative object *Syntax and leave Helper for for backward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen some support in #117, so I made this PR.
It does several things:
syntaxobject and cats-style val's to import syntax;*Helperobjects to be traits & object in order to createsyntax.allcom.evolutiongamin.syntax.allobjects.Note: this is a breaking change, because someone could have been importing implicit classes explicitly, but now they are not available.