Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: eth batch tx is not tested #903

Closed
yihuang opened this issue Jan 14, 2022 · 2 comments
Closed

Problem: eth batch tx is not tested #903

yihuang opened this issue Jan 14, 2022 · 2 comments
Labels
C:JSON-RPC JSON-RPC client Status: Stale Type: Tests issues and PR related to tests

Comments

@yihuang
Copy link
Contributor

yihuang commented Jan 14, 2022

Proposal: add tests for eth batch tx feature

Current behavior: it's verified manually and in cronos integration test, but not in ethermint repo.

Desired behavior: good to add integration test in ethermint repo too.

Use case: [Why is this important (helps with prioritizing requests)]

Requests may be closed if we're not actively planning to work on them.

@yihuang yihuang mentioned this issue Jan 14, 2022
11 tasks
@fedekunze
Copy link
Contributor

we should also add unit tests to the RPC util functions that were introduced in your PR

@fedekunze fedekunze added C:JSON-RPC JSON-RPC client Type: Tests issues and PR related to tests labels Jan 14, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C:JSON-RPC JSON-RPC client Status: Stale Type: Tests issues and PR related to tests
Projects
None yet
Development

No branches or pull requests

2 participants