Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Support legacy ethereum transactions #66

Closed
fedekunze opened this issue Jun 4, 2021 · 0 comments · Fixed by #109
Closed

Support legacy ethereum transactions #66

fedekunze opened this issue Jun 4, 2021 · 0 comments · Fixed by #109
Assignees
@fedekunze

Comments

@fedekunze
Copy link
Contributor

Currently, the MsgEthereumTx only supports AccessList transaction types. Ideally, we should support legacy signing in case someone doesn't want to enable the Berlin fork on the chain Config.

Actionable items:

  • On msg.AsEthereumData, check if AccessList == nil and return a LegacyTx transaction data. If the msg contains a non-nil access list, create an AccessListTx
  • Test message signing with Homestead, EIP155 and Frontier signers (see msg_test.go for ref)
@fedekunze fedekunze added the good first issue Good for newcomers label Jun 4, 2021
@fedekunze fedekunze self-assigned this Jun 9, 2021
@fedekunze fedekunze mentioned this issue Jun 9, 2021
Merged
@fedekunze fedekunze removed the good first issue Good for newcomers label Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fedekunze fedekunze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

evm: support legacy tx evmos/ethermint
1 participant
@fedekunze