From ed4e6b3d60f8720447487e0d80217ea102281d07 Mon Sep 17 00:00:00 2001 From: "azure-pipelines[bot]" Date: Sun, 21 Oct 2018 16:25:39 +0000 Subject: [PATCH 1/7] Set up CI with Azure Pipelines --- azure-pipelines.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 azure-pipelines.yml diff --git a/azure-pipelines.yml b/azure-pipelines.yml new file mode 100644 index 0000000..59ec8a0 --- /dev/null +++ b/azure-pipelines.yml @@ -0,0 +1,20 @@ +# Ruby +# Package your Ruby project. +# Add steps that install rails, analyze code, save build artifacts, deploy, and more: +# https://docs.microsoft.com/azure/devops/pipelines/languages/ruby + +pool: + vmImage: 'Ubuntu 16.04' + +steps: +- task: UseRubyVersion@0 + inputs: + versionSpec: '>= 2.5' + +- script: | + gem install bundler + bundle install --retry=3 --jobs=4 + displayName: 'bundle install' + +- script: bundle exec rake + displayName: 'bundle exec rake' From 594167e506809a7149ad328905504c7e8adb3cf7 Mon Sep 17 00:00:00 2001 From: Evgenii Khramkov Date: Sun, 21 Oct 2018 19:32:38 +0300 Subject: [PATCH 2/7] fix rubocop --- .rubocop.yml | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index b4502ff..2a37233 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -35,11 +35,13 @@ Metrics/ModuleLength: Enabled: false # certificate_1 is an okay variable name -Style/VariableNumber: +Naming/VariableNumber: Enabled: false # This is used a lot across the fastlane code base for config files -Style/MethodMissing: +Style/MethodMissingSuper: + Enabled: false +Style/MissingRespondToMissing: Enabled: false # @@ -76,14 +78,14 @@ Lint/UselessAssignment: - '**/spec/**/*' # We could potentially enable the 2 below: -Style/IndentHash: +Layout/IndentHash: Enabled: false -Style/AlignHash: +Layout/AlignHash: Enabled: false # HoundCI doesn't like this rule -Style/DotPosition: +Layout/DotPosition: Enabled: false # We allow !! as it's an easy way to convert ot boolean @@ -95,7 +97,7 @@ Style/SymbolArray: Enabled: false # We still support Ruby 2.0.0 -Style/IndentHeredoc: +Layout/IndentHeredoc: Enabled: false # This cop would not work fine with rspec @@ -204,7 +206,7 @@ Lint/ParenthesesAsGroupedExpression: # This would reject is_ in front of methods # We use `is_supported?` everywhere already -Style/PredicateName: +Naming/PredicateName: Enabled: false # We allow the $ @@ -212,7 +214,7 @@ Style/PerlBackrefs: Enabled: false # Disable '+ should be surrounded with a single space' for xcodebuild_spec.rb -Style/SpaceAroundOperators: +Layout/SpaceAroundOperators: Exclude: - '**/spec/actions_specs/xcodebuild_spec.rb' @@ -224,7 +226,7 @@ AllCops: - './vendor/**/*' # They have not to be snake_case -Style/FileName: +Naming/FileName: Exclude: - 'fastlane-plugin-appcenter.gemspec' - '**/Dangerfile' @@ -254,4 +256,4 @@ Style/IfInsideElse: # Sometimes we just want to 'collect' Style/CollectionMethods: - Enabled: false + Enabled: false \ No newline at end of file From a85897509ce084f8de4ab52d54e6fcf7d66b5b30 Mon Sep 17 00:00:00 2001 From: Evgenii Khramkov Date: Mon, 19 Nov 2018 14:01:03 +0300 Subject: [PATCH 3/7] publish artifacts --- azure-pipelines.yml | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 59ec8a0..be61b3f 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -11,10 +11,27 @@ steps: inputs: versionSpec: '>= 2.5' -- script: | +- task: bash + script: | gem install bundler bundle install --retry=3 --jobs=4 displayName: 'bundle install' -- script: bundle exec rake +- task: bash + script: bundle exec rake displayName: 'bundle exec rake' + +- task: bash + script: 'rake install' + displayName: 'generate gem' + +- task: CopyFiles@2 + displayName: 'copy generated gem to artifacts folder' + inputs: + Contents: './pkg/*.gem' + TargetFolder: '$(build.artifactstagingdirectory)' + +- task: PublishBuildArtifacts@1 + displayName: 'Publish Artifact: fastlane-plugin-appcenter.gem' + inputs: + ArtifactName: 'fastlane-plugin-appcenter' From 071d779b5e1ef4da89f6103b14fde86bb71e9543 Mon Sep 17 00:00:00 2001 From: Evgenii Khramkov Date: Mon, 19 Nov 2018 14:02:30 +0300 Subject: [PATCH 4/7] fix steps --- azure-pipelines.yml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index be61b3f..b81ed98 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -11,18 +11,15 @@ steps: inputs: versionSpec: '>= 2.5' -- task: bash - script: | +- script: | gem install bundler bundle install --retry=3 --jobs=4 displayName: 'bundle install' -- task: bash - script: bundle exec rake +- script: bundle exec rake displayName: 'bundle exec rake' -- task: bash - script: 'rake install' +- script: 'rake install' displayName: 'generate gem' - task: CopyFiles@2 From c6ca822d3536994d4f01f1fe4aa2648921203031 Mon Sep 17 00:00:00 2001 From: Evgenii Khramkov Date: Mon, 19 Nov 2018 14:04:35 +0300 Subject: [PATCH 5/7] remove redundand config files --- .travis.yml | 4 ---- circle.yml | 9 --------- 2 files changed, 13 deletions(-) delete mode 100644 .travis.yml delete mode 100644 circle.yml diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index 3b35e45..0000000 --- a/.travis.yml +++ /dev/null @@ -1,4 +0,0 @@ -# os: osx # enable this if you need macOS support -language: ruby -rvm: - - 2.2.4 diff --git a/circle.yml b/circle.yml deleted file mode 100644 index 3c3bb8d..0000000 --- a/circle.yml +++ /dev/null @@ -1,9 +0,0 @@ -test: - override: - - bundle exec rake -machine: - ruby: - version: 2.2.4 -# Enable xcode below if you need macOS -# xcode: -# version: "7.3" From 50730104aec52f1cd5a4665179e5ce784c26cd34 Mon Sep 17 00:00:00 2001 From: Evgenii Khramkov Date: Mon, 19 Nov 2018 14:07:04 +0300 Subject: [PATCH 6/7] wip --- azure-pipelines.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index b81ed98..7276ada 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -22,10 +22,13 @@ steps: - script: 'rake install' displayName: 'generate gem' +- script: 'ls -la && cd pkg && ls -la' + displayName: 'debug' + - task: CopyFiles@2 displayName: 'copy generated gem to artifacts folder' inputs: - Contents: './pkg/*.gem' + Contents: 'pkg/**' TargetFolder: '$(build.artifactstagingdirectory)' - task: PublishBuildArtifacts@1 From 2c58903d0583bee023cf096be6a9d552527acce2 Mon Sep 17 00:00:00 2001 From: Evgenii Khramkov Date: Mon, 19 Nov 2018 15:05:10 +0300 Subject: [PATCH 7/7] remove debug step --- azure-pipelines.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 7276ada..0678116 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -22,9 +22,6 @@ steps: - script: 'rake install' displayName: 'generate gem' -- script: 'ls -la && cd pkg && ls -la' - displayName: 'debug' - - task: CopyFiles@2 displayName: 'copy generated gem to artifacts folder' inputs: