Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.add_* and api.update_* functions are not atomic #39

Open
evilnose opened this issue Oct 19, 2020 · 0 comments
Open

api.add_* and api.update_* functions are not atomic #39

evilnose opened this issue Oct 19, 2020 · 0 comments

Comments

@evilnose
Copy link
Owner

For example, if add_node() fails because there is a duplicate ID and the error is caught, a node is still added with partially initialized attributes, since controller.add_node_g() is not atomic.

This is not very urgent since plugins are not likely to need to catch add_node exceptions, but still probably useful to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant