Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping source-map? #141

Closed
elicwhite opened this issue Jul 12, 2016 · 3 comments
Closed

Bumping source-map? #141

elicwhite opened this issue Jul 12, 2016 · 3 comments

Comments

@elicwhite
Copy link

It looks like source-map-support has a dependency on source-map @ 0.1.32 created in September 2014. The current version is 0.5.6. Is there any reason we need to stay on such an old version. We are seeing a flake from inside of source-map via this library via karma-source-map-support and it is really hard to track down the error since we are on such an old version.

For reference of the underlying flake we are having trouble tracking down: sinonjs/sinon#1094

@LinusU
Copy link
Collaborator

LinusU commented Jul 12, 2016

If anyone would like to scan thru the changelog and see if there any breaking changes we should be aware of, that would be much appreciated. I'm okay with bumping the dependency if it looks good

@seanpoulter
Copy link
Contributor

seanpoulter commented Mar 11, 2017

source-map was updated in 9fd4c64 to version 0.5.3.
The Mocha tests still pass if we update source-map to 0.5.6. I can submit the PR if it's easier for you @LinusU.

@LinusU
Copy link
Collaborator

LinusU commented Mar 13, 2017

I would love that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants