Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pagination command text doesn't use Locale language #650

Closed
krisaggio opened this issue May 26, 2017 · 3 comments
Closed

The pagination command text doesn't use Locale language #650

krisaggio opened this issue May 26, 2017 · 3 comments

Comments

@krisaggio
Copy link
Contributor

Expected Behavior

The "say next", "say previous" and the pages text should change within the selected languages.
Being hardcoded might be a good idea externalize it with the languages files in /locales

Steps to Reproduce (for bugs)

1.Change to any other language rather than English
2.Trigger the show command list.
3.The "say next", "say previous" and the pages text with be shown in English and wont work.

Context

Browsing the command list menu, moving between pages.

Your Environment

Raspberry Pi 3, node.js v6.10.3
Raspbian 4.9.27

@justbill2020 justbill2020 mentioned this issue May 26, 2017
5 tasks
@evancohen
Copy link
Owner

Yup! This is a localization bug. This should totally be fixed.

@justbill2020 justbill2020 changed the title The "say next", "say previous" and the pages text do not works with others languages The pagination command text doesn't use Locale language Jun 15, 2017
@justbill2020
Copy link
Collaborator

just wrote the code to fix this... not sure i like it i'll push a commit with this and other stuff in #642 later on after i do some testing...

@sdetweil
Copy link
Collaborator

sdetweil commented May 3, 2020

@justbill2020 did u ever test this? do you have the code still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants