Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: MSRV #52

Closed
Emoun opened this issue Dec 5, 2020 · 2 comments
Closed

Request: MSRV #52

Emoun opened this issue Dec 5, 2020 · 2 comments

Comments

@Emoun
Copy link
Contributor

Emoun commented Dec 5, 2020

I would like request that macrotest decides on a Minimum Supported Rust Version (MSRV).

The latest release 1.0.6 doesn't build on Rust v1.34.
This is a problem for duplicate, as we have an MSRV of 1.34. Therefore, it cannot update to the latest version: see this build result.
As long as macrotest doesn't commit to an MSRV (that is compatible with duplicate's), I must assume each release (even patch releases) may break our setup.

Of course, I would prefer that the eventual MSRV chosen for macrotest be compatible with duplicate's MSRV.
It can be found on crates.io in the "MSRV Policy" section.
You can also see how I decided on an MSRV policy on this issue.
You can also look at the Github Actions and Travis CI setups for how duplicate enforces the MSRV.

Even if macrotest doesn't get and MSRV of 1.34, I would prefer to know what the policy is. I can then use that knowledge to guide any MSRV policy updates.

@eupn
Copy link
Owner

eupn commented Dec 11, 2020

Hello @Emoun and sorry for making your code break. I'll definitely make sure that this crate has MSRV and it seems that it could work with 1.34 (thanks to #53).

@eupn
Copy link
Owner

eupn commented Dec 11, 2020

The v1.0.7 version should support 1.34.0 and higher. Please feel free to reopen this issue if this is not the case, now or in the future.

@eupn eupn closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants