feat(decoder): add FFDC marker support #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/decoder.js
Outdated
| @@ -782,6 +782,11 @@ var JpegImage = (function jpegImage() { | |||
| resetInterval = readUint16(); | |||
| break; | |||
|
|
|||
| case 0xFFDC: // Number of Lines marker | |||
| readUint16() // skip data length | |||
| this.numberOfLines = readUint16() | |||
There was a problem hiding this comment.
is this number ever different from the height of the image?
There was a problem hiding this comment.
actually it is a pretty worthless information, but I felt bad checking a data and ignoring it, I guess we can ignore it since this marker is deprecated
There was a problem hiding this comment.
Switched to just ignoring the marker, thank you for your review!
patrickhulce
requested changes
Aug 21, 2020
test/index.js
Outdated
| @@ -1,141 +1,143 @@ | |||
| var fs = require('fs'), | |||
There was a problem hiding this comment.
revert all these changes?
There was a problem hiding this comment.
Oh right i'm sorry, format on save option... reverted now
patrickhulce
approved these changes
Aug 24, 2020
|
many thanks @Chupsy! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thank you for all you hard work on this project, easy to use and very clear to understand.
This PR aims to fix an issue where files using the FFDC marker were refused with the error "Unknown JPEG marker ffdc". Even though it is a rare marker, which simply gives another info of the height of the file, I added the handling and tests for this marker.
Thank you for your time reviewing this PR