- added possibility to write comment tags

[brainbugfix]

I added the possibility to add the comments to the image during encoding as they come from decoding or added manually

[patrickhulce]

thanks @brainbugfix! add a round-trip test for this?

types will also need to be updated

[patrickhulce]

Suggested change

	if (typeof comments === "undefined") return;
	if (typeof comments !== 'string') return;

perhaps? but ya know, inside the loop with an array check here :)

[brainbugfix]

This will not work, I am afraid. The type is 'object' as it is an array.

[brainbugfix]

Ah sorry, misunderstood your comment. I will change that tomorrow.

[patrickhulce]

thanks that change looks great, would you mind tackling...

add a round-trip test for this?
types will also need to be updated

:D

[brainbugfix]

I am not sure if I understand what you want me to do. I can add a test, that should not be a big deal but what exactly do you mean with updating the types?

[patrickhulce]

Oh sorry, I mean update the typescript definitions in index.d.ts at

jpeg-js/index.d.ts

Line 13 in 417e8e2

export declare function encode(imgData: RawImageData<BufferLike>, quality?: number): BufferRet;

It's already a bit out of date but just changing the first encode parameter to RawImageData<BufferLike> & {comments?: string[]} should work?

[brainbugfix]

Did what you asked me for. Can you please double-check the TypeScript because I've never used this before.

[patrickhulce]

thanks @brainbugfix this is great!

[patrickhulce]

if all these suggestions are ok with you @brainbugfix I'm ready to merge! :)

[patrickhulce]

thanks again :)