Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Peak Extraction #766

Open
ddlidded opened this issue Feb 12, 2025 · 2 comments
Open

Issue with Peak Extraction #766

ddlidded opened this issue Feb 12, 2025 · 2 comments
Assignees
Labels
bug external Request/issue from outside Calico question
Milestone

Comments

@ddlidded
Copy link

ddlidded commented Feb 12, 2025

After the latest update, it seems that after clicking on a peak when the "Full" is filled in through the scan filter, it seems to decrease the ppm window to where the scans are not fully picked up. After adjusting the ppm window to a different value then back to the original, the problem goes away until you view the compound again through the bookmarks tab. Take a look at what I mean below:

Image

After retyping the ppm window, the scans magically appear again, but not when accessing through bookmark tab!

Image

Image

It fixed the SIM scan issue, however this issue now occurs, if it could be addressed that would be fantastic! This is maven version 2.10.22. @PMSeitzer

@PMSeitzer PMSeitzer added bug external Request/issue from outside Calico labels Feb 12, 2025
@PMSeitzer
Copy link
Collaborator

Thanks for letting me know @ddlidded - I think what's going on is that the actual bookmarked peak itself is very narrow in RT (note the small circles), and the m/z range observed in that small set of scans is likely very small. The "missing" scans you are seeing are actually scans that are technically outside of the RT range of the peak.

I think the solution is to pick a wider peak - and there a few ways you can do that.

The easiest way to pick a larger pick is to define the peak manually using SHIFT + click and drag, over the RT range you want for the peak. That way you can either pick up or explicitly exclude long tails and shoulders, and deal with any other strange stuff.

Alternatively, you can modify the peak detection parameters, so that the peak RT bounds are automatically a little wider. You can increase the smoothing window, or adjust the RT bounds parameters (available in the options dialog).

@PMSeitzer PMSeitzer self-assigned this Feb 12, 2025
@PMSeitzer PMSeitzer added this to the 2.10.23 milestone Feb 12, 2025
@ddlidded
Copy link
Author

ddlidded commented Feb 13, 2025

@PMSeitzer Also, it seems that in negative mode, the scans are still not continuous when using polarity switching (even after extracting the negative mzXML file). See Image attached Below. Positive mode looks good, however negative mode does not. Please let me know if you need me to attach an example file for you.

Are both of these issues something that can be addressed in the next release? It is quite annoying to have to do that when clicking on a bookmark when this was never the case before. Not sure how hard it is to fix that, but would be appreciated!

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug external Request/issue from outside Calico question
Projects
None yet
Development

No branches or pull requests

2 participants