-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add swap-endpoint migration #298
Conversation
// this is a migration path for pioneers | ||
// who helped testing the early versions | ||
if (!config.password) { | ||
writeConfigYaml({ password: 'Test' }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better name would be patchConfigYaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great step refactoring it into a separate file. This is, although starting to creep into more and more complex migrations. It would be a good idea to consider some more complex migration framework, which would keep the versioned state in order to understand what changes needs to be made. But that is out of scope for now, so lets merge this and I have created issue about this so we can discuss it later on: #304
No description provided.