Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add swap-endpoint migration #298

Merged
merged 4 commits into from
Dec 19, 2022
Merged

feat: add swap-endpoint migration #298

merged 4 commits into from
Dec 19, 2022

Conversation

Cafe137
Copy link
Collaborator

@Cafe137 Cafe137 commented Dec 5, 2022

No description provided.

@Cafe137 Cafe137 linked an issue Dec 5, 2022 that may be closed by this pull request
@Cafe137 Cafe137 marked this pull request as ready for review December 15, 2022 09:30
// this is a migration path for pioneers
// who helped testing the early versions
if (!config.password) {
writeConfigYaml({ password: 'Test' })
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better name would be patchConfigYaml

Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great step refactoring it into a separate file. This is, although starting to creep into more and more complex migrations. It would be a good idea to consider some more complex migration framework, which would keep the versioned state in order to understand what changes needs to be made. But that is out of scope for now, so lets merge this and I have created issue about this so we can discuss it later on: #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace config's swap-endpoint with blockchain-rpc-endpoint
2 participants