Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect references to trie in tests #345

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Conversation

kn
Copy link
Contributor

@kn kn commented Aug 26, 2018

In the current master, npm test raises the following error:

TAP version 13
# test the cache api
# should have the correct value in the cache
/Users/kn/repos/ethereumjs-vm/tests/cacheTest.js:65
      vm.trie.put(Buffer.from(account1.address, 'hex'), account.serialize(), cb)
              ^

TypeError: Cannot read property 'put' of undefined

This PR fixes it by correcting references to trie.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, tests are not actively included in the CI testing atm, but having these up-to-date can't hurt anyhow.

Will directly merge since this is not touching any production (test) code.

@holgerd77 holgerd77 merged commit cef738d into ethereumjs:master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants