Add EXTCODEHASH opcode implementation #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
axic
reviewed
Jul 30, 2018
| @@ -288,6 +288,18 @@ module.exports = { | |||
| cb(null) | |||
| }) | |||
| }, | |||
| EXTCODEHASH: function (address, runState, cb) { | |||
| var stateManager = runState.stateManager | |||
There was a problem hiding this comment.
Need to add check if it is on constantinople, otherwise throw.
There was a problem hiding this comment.
👍 (Note to self: check that there are state tests that cover this edge case)
|
I'm not sure what is the proper process: are there any state tests merged for this yet? If not, should we merge it and then fix once the tests are added? I think I vote for merging and lets assume the tests will be added as they are required for consensus. |
|
Sounds good to me. I'm working on state tests for |
|
Moving this to: #326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.