From 0247ed407079c0fdb4d90fd13f754ed59ffe1e87 Mon Sep 17 00:00:00 2001 From: Keri Date: Thu, 19 Nov 2020 13:06:59 -0700 Subject: [PATCH 1/2] Remove unneeded pytestmark warnings --- tests/core/contracts/test_extracting_event_data_old.py | 3 --- tests/core/filtering/test_contract_past_event_filtering.py | 3 --- 2 files changed, 6 deletions(-) diff --git a/tests/core/contracts/test_extracting_event_data_old.py b/tests/core/contracts/test_extracting_event_data_old.py index e100762125..7cd0a391e9 100644 --- a/tests/core/contracts/test_extracting_event_data_old.py +++ b/tests/core/contracts/test_extracting_event_data_old.py @@ -8,9 +8,6 @@ get_event_data, ) -# Ignore warning in pyethereum 1.6 - will go away with the upgrade -pytestmark = pytest.mark.filterwarnings("ignore:implicit cast from 'char *'") - @pytest.fixture() def Emitter(web3, EMITTER): diff --git a/tests/core/filtering/test_contract_past_event_filtering.py b/tests/core/filtering/test_contract_past_event_filtering.py index 0a5bfa5397..85009ef824 100644 --- a/tests/core/filtering/test_contract_past_event_filtering.py +++ b/tests/core/filtering/test_contract_past_event_filtering.py @@ -4,9 +4,6 @@ is_same_address, ) -# Ignore warning in pyethereum 1.6 - will go away with the upgrade -pytestmark = pytest.mark.filterwarnings("ignore:implicit cast from 'char *'") - @pytest.mark.parametrize('call_as_instance', (True, False)) @pytest.mark.parametrize('api_style', ('v4', 'build_filter')) From e1f4ceb793c7931e5b029283801fb3fcf7e6148b Mon Sep 17 00:00:00 2001 From: Keri Date: Thu, 19 Nov 2020 15:52:11 -0700 Subject: [PATCH 2/2] Add newsfragment for pytest warning --- newsfragments/1796.misc.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 newsfragments/1796.misc.rst diff --git a/newsfragments/1796.misc.rst b/newsfragments/1796.misc.rst new file mode 100644 index 0000000000..ac985713c4 --- /dev/null +++ b/newsfragments/1796.misc.rst @@ -0,0 +1 @@ +Remove un-needed pytest.mark.filterwarnings("ignore:implicit cast from 'char *'") that we had in the tests.