Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py3.13 to supported versions #3493

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Sep 20, 2024

What was wrong?

py3.13 is here! And CI supports it

How was it fixed?

Add 3.13 to supported and tested versions.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

image

@kclowes
Copy link
Collaborator

kclowes commented Oct 16, 2024

Woohoo! I don't see anything obvious, but the py313-* tests seem to have way more tests than the others. For example, py313-core has 8427 tests, and py311-core and py312-core both have 2366.

@pacrob pacrob self-assigned this Oct 21, 2024
@pacrob pacrob force-pushed the add-py313-support branch from ce6bbb5 to 256e5dc Compare October 22, 2024 19:42
@pacrob pacrob force-pushed the add-py313-support branch from 256e5dc to 8383e39 Compare October 22, 2024 19:54
@pacrob
Copy link
Contributor Author

pacrob commented Oct 22, 2024

Woohoo! I don't see anything obvious, but the py313-* tests seem to have way more tests than the others. For example, py313-core has 8427 tests, and py311-core and py312-core both have 2366.

Not sure what happened, but I added the newsfragment and now runs are matching (I checked core, async-core, and ens) 🤷

@pacrob pacrob marked this pull request as ready for review October 22, 2024 20:07
@pacrob pacrob requested review from kclowes and reedsa October 22, 2024 20:07
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pacrob pacrob merged commit 3c412f8 into ethereum:main Oct 23, 2024
85 checks passed
@pacrob pacrob deleted the add-py313-support branch October 23, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants