Eth tester fee history #3222
Merged
Eth tester fee history #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
approved these changes
Feb 5, 2024
kclowes
force-pushed
the
eth-tester-fee-history
branch
from
864cc62 to
01048f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Now that we have an eth-tester version compatible with web3.py v6 that includes
feeHistory, we can add it here.Related to Issue #
How was it fixed?
Bumped eth-tester to a compatible version, then cherry picked the commit from @fselmo that actually made the changes. I noticed there were a few tests that were unneeded, so removed those.
Todo:
Cute Animal Picture