Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Access List Async RPC Method #3167

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Create Access List Async RPC Method #3167

merged 4 commits into from
Dec 18, 2023

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Dec 12, 2023 •
edited
Loading

What was wrong?

Closes #3163

How was it fixed?

Implement RPC method for async createAccessList

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@reedsa reedsa requested review from fselmo, kclowes and pacrob December 13, 2023 19:52
pacrob
pacrob approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

kclowes
kclowes approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I realized that the async flaky integration tests aren't running either, so I just put up a quick PR (#3170).

@kclowes kclowes mentioned this pull request Dec 15, 2023
Merged
1 task
fselmo
fselmo approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiniest of nits, lgtm, take or leave 👍🏼

@reedsa reedsa merged commit 09048b2 into ethereum:main Dec 18, 2023
@reedsa reedsa deleted the async-create-access-list branch March 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@pacrob pacrob pacrob approved these changes

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async createAccessList
4 participants
@reedsa @fselmo @pacrob @kclowes