Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shanghai eth tester changes #2958

Merged
merged 7 commits into from
May 12, 2023
Merged

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented May 12, 2023

  • Shanghai support for eth-tester + py-evm and add appropriate formatters and tests
  • Update BlockData to include withdrawals and withdrawalsRoot fields
  • Peripheral updates related to above changes

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

fselmo added 6 commits May 1, 2023 15:52
- add ``withdrawals`` and ``withdrawalsRoot`` to ``BlockData`` type
- create a ``Gwei`` type
- create a ``WithdrawalData`` type for appropriately typing withdrawals
- format ``validator_index`` (snakecase) to ``validatorIndex`` (camelCase)
- add test directory for directly testing eth-tester specific api and add a withdrawals test
@fselmo fselmo force-pushed the shanghai-eth-tester-changes branch from f50d741 to 5524a43 Compare May 12, 2023 19:07
@fselmo fselmo requested review from kclowes and pacrob May 12, 2023 19:42
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚢

@fselmo fselmo marked this pull request as ready for review May 12, 2023 20:50
@fselmo fselmo force-pushed the shanghai-eth-tester-changes branch from 55ceefc to 309357a Compare May 12, 2023 20:56
@fselmo fselmo merged commit 64b9b11 into ethereum:main May 12, 2023
@fselmo fselmo deleted the shanghai-eth-tester-changes branch April 3, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants