Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async web3 docs #2821

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Async web3 docs #2821

merged 6 commits into from
Feb 22, 2023

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Feb 16, 2023

What was wrong?

This PR builds on #2819.

How was it fixed?

Added some docs for the AsyncHTTPProvider!

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes requested review from wolovim, fselmo and pacrob February 16, 2023 23:52
@fselmo fselmo mentioned this pull request Feb 22, 2023
2 tasks
@kclowes kclowes marked this pull request as ready for review February 22, 2023 21:24
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼 Thanks!

@kclowes kclowes merged commit 3ea896c into ethereum:master Feb 22, 2023
@kclowes kclowes deleted the async-web3-docs branch February 22, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants