Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfshttpclient is unmaintained #2629

Closed
RaitoBezarius opened this issue Sep 5, 2022 · 5 comments · Fixed by #2730
Closed

ipfshttpclient is unmaintained #2629

RaitoBezarius opened this issue Sep 5, 2022 · 5 comments · Fixed by #2730

Comments

@RaitoBezarius
Copy link

  • Version: not-relevant
  • Python: not-relevant
  • OS: not-relevant
  • pip freeze output
not-relevant

What was wrong?

According to ipfs-shipyard/py-ipfs-http-client#316 and NixOS/nixpkgs#185294 ; we surmise that ipfshttpclient is currently unmaintained or has some breakages unresolved at the moment.

I wanted to understand if you had plans to migrate away to another library or mark the IPFS backend as an extra module or deprecated for now?

How can it be fixed?

  • Drop the IPFS backend (deprecation)
  • Move it as an extra module (with appropriate documentation)
  • Offer up help to maintain the Python IPFS HTTP client
  • Move to another library (homegrown or whatever.)
@PancakesArchitect
Copy link

I maintain this library which is now compliant with kubo 0.15, but it's only usable with asyncio.

ipfshttpclient currenly supports the RPC API of go-ipfs between version 0.5.0 and 0.9.0 (i often patched ipfshttpclient.client.assert_version to make it work with later versions). There's a little bit of work involved to make it compliant with kubo but it's doable, would be happy to help.

@Polsaker
Copy link
Contributor

Move it as an extra module (with appropriate documentation)

Another option: Making the IPFS backend opt-in. I bet most people using this library won't be using this and those that want to use this can just install web3[ipfs]

@step21
Copy link
Contributor

step21 commented Oct 14, 2022

On that note, as packager of the web3.py package for conda-forge, where do you get your ipfshttpclient from? currently setup.py wants 0.8.2 something, but according to pypi and github the latest version is 0.7.0.

@fselmo
Copy link
Collaborator

fselmo commented Oct 18, 2022

On that note, as packager of the web3.py package for conda-forge, where do you get your ipfshttpclient from? currently setup.py wants 0.8.2 something, but according to pypi and github the latest version is 0.7.0.

We use 0.8.0a2. PR #2110 for context.

@fselmo
Copy link
Collaborator

fselmo commented Oct 18, 2022

Thanks for raising this @RaitoBezarius. We don't currently have IPFS on the immediate roadmap so this fell by the wayside for a bit. I would be supportive of re-organizing the backend as opt-in. PRs are welcome otherwise we will try to get to this soon, ideally before v6 moves to stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants