Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hint for dict in the example doc #2469

Merged
merged 2 commits into from
May 12, 2022
Merged

Conversation

kaiix
Copy link
Contributor

@kaiix kaiix commented May 12, 2022

What was wrong?

Advanced example: Fetching all token transfer events use {} as the dict type hint, which is wrong.

@pacrob
Copy link
Contributor

pacrob commented May 12, 2022

Thanks, @kaiix ! You are correct, we should not be using {}, but it looks like we prefer to use Dict instead of dict most everywhere else. Would you mind making that small change? If you're especially motivated, it looks like we have a few more uses of {} that could be updated too, but not necessary.

@kaiix
Copy link
Contributor Author

kaiix commented May 12, 2022

Thanks, @kaiix ! You are correct, we should not be using {}, but it looks like we prefer to use Dict instead of dict most everywhere else.

Everywhere else in example.rst uses dict as type hint, should it all be changed to Dict?

it looks like we have a few more uses of {} that could be updated too, but not necessary.

I haven't found anywhere else that uses {} as type hint, so if you do, let me know and I'll be willing to help.

@pacrob
Copy link
Contributor

pacrob commented May 12, 2022

Everywhere else in example.rst uses dict as type hint, should it all be changed to Dict?

Yes please!

I haven't found anywhere else that uses {} as type hint, so if you do, let me know and I'll be willing to help.

You're right, my mistake. Just the dicts then.

@pacrob
Copy link
Contributor

pacrob commented May 12, 2022

Looks good! No worry about the failing tests, we're working on the timeouts. Thank you!

@pacrob pacrob merged commit d246b81 into ethereum:master May 12, 2022
@kaiix kaiix deleted the fix-example branch May 13, 2022 02:18
pacrob pushed a commit that referenced this pull request May 23, 2022
* Fix type hint for dict in the example doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants