[WIP] Implement web3.eth.Eth.createAccessList
#2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
reviewed
Mar 7, 2022
There was a problem hiding this comment.
I saw your comment on the issue, and your approach looks to be about right on a high level. Thanks for adding such detailed docs. I added a few comments on the code. One thing that may help with the formatters is to write the integration test, and see what you get back. Let me know if you need direction on that front. Thanks @Harmouch101!
wiseaidev
force-pushed
the
eth-createAccessList
branch
4 times, most recently
from
cd2d875 to
afece45
Compare
|
wiseaidev@afece45#r85299196. How to add the up for grabs tag ? |
reedsa
force-pushed
the
eth-createAccessList
branch
from
afece45 to
38138a7
Compare
reedsa
force-pushed
the
eth-createAccessList
branch
from
ada62a3 to
8aa5088
Compare
pacrob
reviewed
Dec 4, 2023
pacrob
reviewed
Dec 4, 2023
pacrob
reviewed
Dec 4, 2023
fselmo
reviewed
Dec 5, 2023
reedsa
force-pushed
the
eth-createAccessList
branch
from
a33ce35 to
33fc46b
Compare
pacrob
reviewed
Dec 5, 2023
3 tasks
reedsa
force-pushed
the
eth-createAccessList
branch
from
d30f651 to
5c48f46
Compare
fselmo
reviewed
Dec 7, 2023
| } | ||
| ) | ||
| ), | ||
| apply_formatter_to_array(ACCESS_LIST_FORMATTER), |
Signed-off-by: Harmouch101 <eng.mahmoudharmouch@gmail.com>
reedsa
force-pushed
the
eth-createAccessList
branch
from
fa135bf to
0ac51c6
Compare
fselmo
approved these changes
Dec 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harmouch101 eng.mahmoudharmouch@gmail.com
What was wrong?
Related to Issue #2258
How was it fixed?
Ref: Lord Vitalik.
Todo:
Cute Animal Picture
🐶