Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support EIP-1559 params for signTransaction #2065

Closed
fselmo opened this issue Jul 8, 2021 · 1 comment
Closed

Support EIP-1559 params for signTransaction #2065

fselmo opened this issue Jul 8, 2021 · 1 comment
Assignees
@fselmo

Comments

@fselmo
Copy link
Collaborator

fselmo commented Jul 8, 2021 •
edited
Loading

What was wrong?

  • geth does not yet have support for the new 1559 params for the signTransaction RPC call [Support added in 1.10.5]
  • Waiting on eth-account 1559 support - PR #115

How can it be fixed?

  • Once geth has support for params maxFeePerGas and maxPriorityFeePerGas for signing... and eth-account is updated to support the params... we should make sure we support this on our end and update the related tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fselmo fselmo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fselmo @kclowes