Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx-apidoc command to exclude benchmarking docs #2021

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Jun 9, 2021

What was wrong?

Every time make build-docs was run, a docs/web3.tools.benchmark.rst file was auto generated by sphinx-apidoc.

How was it fixed?

Added web3/tools to the list of exclude patterns for apidoc. Also removed the web3/utils pattern since we no longer have a utils file.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes force-pushed the sphinx-exclude-benchmark branch from cd3d66e to fdb47ff Compare June 9, 2021 21:44
@kclowes kclowes requested a review from wolovim June 9, 2021 21:59
Copy link
Member

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for cleaning that up 🙏

@kclowes kclowes merged commit 73d1c7c into ethereum:master Jun 10, 2021
@kclowes kclowes deleted the sphinx-exclude-benchmark branch June 10, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants