deprecate generateGasPrice in favor of snakecased generate_gas_price #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmckenzie51
changed the title
tmckenzie51
force-pushed
the
tiffany/generateGasPrice-to-snakecase
branch
from
39b3087 to
e96fece
Compare
tmckenzie51
force-pushed
the
tiffany/generateGasPrice-to-snakecase
branch
from
48c13e2 to
0a74e66
Compare
kclowes
approved these changes
Mar 31, 2021
| @@ -14,14 +14,14 @@ def test_get_set_gasPrice(web3): | |||
|
|
|||
|
|
|||
| def test_no_gas_price_strategy_returns_none(web3): | |||
There was a problem hiding this comment.
Is this the one we paired on trying to add a deprecation warning? If not, I'd expect a test that ensures the DeprecationWarning gets raised somewhere in this file.
Co-authored-by: kclowes <kclowes@users.noreply.github.com>
Co-authored-by: kclowes <kclowes@users.noreply.github.com>
Co-authored-by: kclowes <kclowes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Added generate_gas_price, deprecated generateGasPrice
Related to Issue #1429
Todo:
Cute Animal Picture