flake8 upgrade to 3.8.3 #1759
Merged
flake8 upgrade to 3.8.3 #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
reviewed
Oct 2, 2020
setup.py
Outdated
| extras_require['docs'] + | ||
| extras_require['dev'] | ||
| extras_require['tester'] | ||
| + extras_require['linter'] # noqa: W503 |
There was a problem hiding this comment.
I would be ok with adding W503 to the ignored warnings in our tox.ini file.
There was a problem hiding this comment.
yeah. right! will do
pipermerriam
approved these changes
Oct 2, 2020
|
(also, you should work on getting CI passing) |
some of the CI will fail because of Known issue with Infura IPFS endpoint |
kclowes
force-pushed
the
flake-upgrade
branch
from
cffa3ef to
1464074
Compare
|
@pratik-vii thanks for taking this on! I just pulled in the most recent master that should have the tests fixed, so as soon as those pass, I'll pull this in. 🎉 |
kclowes
force-pushed
the
flake-upgrade
branch
from
a5d2f44 to
b88a419
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1720
How was it fixed?
Cute Animal Picture