Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add context to quickstart guide #1673

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Jun 17, 2020

What was wrong?

Nothing egregious, but thought we could slow down and connect a couple more dots in the quickstart section.

How was it fixed?

  • Added more explicit Provider descriptions with example guides for local Geth nodes and Infura providers.
    • The existing Infura guide was augmented a bit, but my assumption is that the other most popular use case worth addressing is the local Geth node scenario (whether in --dev mode or not). Trinity Soon™ 🤞
    • The local node case also feels prudent for encouraging decentralization. Don't think it makes sense to discuss that philosophically in a quickstart guide, however.
  • Removed a couple small things that felt out of the scope of a quickstart guide.

Preview link: https://web3py--1673.org.readthedocs.build/en/1673/quickstart.html

Todo:

Cute Animal Picture

Copy link
Contributor

@cburgdorf cburgdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice overhaul 👍

@wolovim wolovim merged commit 493bd62 into ethereum:master Jun 17, 2020
@wolovim wolovim deleted the onboarding-docs-pt2 branch June 17, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants