Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble up tx signing errors #3105

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Bubble up tx signing errors #3105

merged 4 commits into from
Oct 8, 2019

Conversation

gabmontes
Copy link
Contributor

Team, now that version 1.x is out, this patch (originally #2063) is relevant again for that branch. As mentioned by @nivida the issue was possibly solved in #2000 but that applies to the 2.x branch.

Please reconsider accepting this change for 1.x.

@coveralls
Copy link

coveralls commented Oct 7, 2019

Coverage Status

Coverage decreased (-0.2%) to 83.157% when pulling 5923816 on bloq:capture-send-err into 28d52a9 on ethereum:1.x.

@cgewecke cgewecke added the 1.x 1.0 related issues label Oct 7, 2019
@nivida nivida added the Bug Addressing a bug label Oct 8, 2019
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this PR! Could you updated the CHANGELOG.md file in the root folder the 1.x branch. (I will updated and fix the the PR template asap)

@gabmontes
Copy link
Contributor Author

@nivida changelog updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants