Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an rpc test confirming that we support batched requests #1571

Closed
carver opened this issue Oct 30, 2024 · 7 comments
Closed

Add an rpc test confirming that we support batched requests #1571

carver opened this issue Oct 30, 2024 · 7 comments

Comments

@carver
Copy link
Collaborator

carver commented Oct 30, 2024

For the automated test, here is a batch example in alloy here:
https://crates.io/crates/alloy-rpc-client

It would be nice to run a manual gut-check test that the same works in web3.py, a la:
https://web3py.readthedocs.io/en/stable/web3.main.html#batch-requests

@oac1771
Copy link
Contributor

oac1771 commented Jan 11, 2025

Hello! Can I be assigned to this issue?

@ogenev
Copy link
Member

ogenev commented Jan 13, 2025

Hello! Can I be assigned to this issue?

No need to be assigned, open a PR when you are ready 😸.

@oac1771
Copy link
Contributor

oac1771 commented Jan 13, 2025

Sweet, I will work on it now. I do have a follow up question though.

How exactly to you run the tests found in the root test directory? I looked through the trin book, but didnt see anything and I also ran the make test commands that I found in the circle ci config file which doesnt seem to run those tests. Thanks!

@KolbyML
Copy link
Member

KolbyML commented Jan 13, 2025

Sweet, I will work on it now. I do have a follow up question though.

How exactly to you run the tests found in the root test directory? I looked through the trin book, but didnt see anything and I also ran the make test commands that I found in the circle ci config file which doesnt seem to run those tests. Thanks!

That should be fix in this PR #1632

The tests folder must be winthin a crate, currently it isn't.

For the reasoning why #1632 fixes it is here #1633 (comment)

It should be merged tomorrow, so you can begin your work then

@oac1771
Copy link
Contributor

oac1771 commented Jan 13, 2025

Sweet thanks, ill keep an eye out

@oac1771
Copy link
Contributor

oac1771 commented Jan 16, 2025

Hello, I have opened a PR for this

@ogenev
Copy link
Member

ogenev commented Jan 17, 2025

Resolved in #1638.

@ogenev ogenev closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants