-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an rpc test confirming that we support batched requests #1571
Comments
Hello! Can I be assigned to this issue? |
No need to be assigned, open a PR when you are ready 😸. |
Sweet, I will work on it now. I do have a follow up question though. How exactly to you run the tests found in the root test directory? I looked through the trin book, but didnt see anything and I also ran the |
That should be fix in this PR #1632 The For the reasoning why #1632 fixes it is here #1633 (comment) It should be merged tomorrow, so you can begin your work then |
Sweet thanks, ill keep an eye out |
Hello, I have opened a PR for this |
Resolved in #1638. |
For the automated test, here is a batch example in alloy here:
https://crates.io/crates/alloy-rpc-client
It would be nice to run a manual gut-check test that the same works in web3.py, a la:
https://web3py.readthedocs.io/en/stable/web3.main.html#batch-requests
The text was updated successfully, but these errors were encountered: