Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tight packing should take number constants as uint256 #982

Closed
axic opened this issue Aug 31, 2016 · 3 comments
Closed

Tight packing should take number constants as uint256 #982

axic opened this issue Aug 31, 2016 · 3 comments

Comments

@axic
Copy link
Member

axic commented Aug 31, 2016

Unless explicitly typecasted to a shorter type.

I'm not fully sure which is the better behaviour, but I think this is more explicit and less prone to error.

@chriseth
Copy link
Contributor

In general, I try to keep everything as uniform as possible. This exception might be useful for some cases, but it still is an exception that has to be explicitly documented.

@axic
Copy link
Member Author

axic commented Aug 25, 2017

Since #2813 there is a warning for this. It could be turned into an error if this is decided on.

@chriseth
Copy link
Contributor

I would opt for turning the existing warning into an error for 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants