Migrate imports from eth.utils to eth_utils #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashutoshrathi
changed the title
|
@cburgdorf review |
|
@aashutoshrathi Thank you for the PR. I'll review it on (my) Monday which means in about 15 hours or so :) |
cburgdorf
reviewed
Nov 12, 2018
aashutoshrathi
force-pushed
the
migrate
branch
from
eaffb1e to
70768a2
Compare
|
ping @cburgdorf |
cburgdorf
reviewed
Nov 12, 2018
There was a problem hiding this comment.
I feel really sorry about the nitpicking but can you also ensure the import order is correct as explained here: https://github.com/ethereum/snake-charmers-tactical-manual/blob/master/style-guide.md#overall-ordering
aashutoshrathi
force-pushed
the
migrate
branch
from
04dfed7 to
0b12209
Compare
cburgdorf
approved these changes
Nov 13, 2018
|
Merged! ✨ Thank you for your contribution 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1454
What was wrong?
There are currently many small utility functions that exist in eth.utils but also exist in the standalone eth_utils library by now. These functions should really be imported from eth_utils and removed from this code base.
Also added PEP8 fixes 😉
How was it fixed?
Using this PR
Cute Animal Picture