Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beacon chain data classes #1333

Closed
hwwhww opened this issue Sep 28, 2018 · 0 comments · Fixed by #1338
Closed

Add beacon chain data classes #1333

hwwhww opened this issue Sep 28, 2018 · 0 comments · Fixed by #1338
Assignees
Labels

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Sep 28, 2018

What is wrong?

#930 - part 2 - moving the data classes from beacon_chain repo to Py-EVM.

How can it be fixed

In beacon_chain repo, there some classes:

  • active_state.py
  • attestation_record.py
  • block.py
  • crosslink_record.py
  • crystallized_state.py
  • shard_and_committee.py
  • validator_record.py

In the Eth2.0 call yesterday, Alexey pointed out some problems with SimpleSerialize. At this point, I suggest we use RLP for now before it's standardized. @djrtwo any thoughts?

Action:

  • Move these classes to eth/beacon/types/
  • Move tests to tests/core/beacon/types/

Note: there are some handy cache data in ActiveState, I think we can remove it and add some other Py-EVM style cache mechanism later.

@hwwhww hwwhww added the eth2.0 label Sep 28, 2018
@hwwhww hwwhww self-assigned this Sep 30, 2018
@hwwhww hwwhww mentioned this issue Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant