p2p/enode: add quic ENR entry #30283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Aug 9, 2024
|
Not sure if we actually need the accessor on |
fjl
reviewed
Aug 9, 2024
guillaumemichel
force-pushed
the
enr-quic
branch
from
2db0c5c
to
299eff3
Compare
|
I added a few more tests here. It didn't seem like the included test was really verifying the port was loaded correctly. Also verifying we don't return an endpoint with a quic6 port for IPv4 and vice versa. Not sure how important that is. |
lightclient
approved these changes
Aug 18, 2024
|
Any update on the status of this PR? |
|
Is the PR good for merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
quicentry to the ENR as proposed in ethereum/consensus-specs#3644Allowing to read Lighthouse
quicport from ENR.