Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnTxEnd panics in some testing tools #30117

Closed
lightclient opened this issue Jul 3, 2024 · 0 comments · Fixed by #30332
Closed

OnTxEnd panics in some testing tools #30117

lightclient opened this issue Jul 3, 2024 · 0 comments · Fixed by #30332
Labels
type:bug

Comments

@lightclient
Copy link
Member

lightclient commented Jul 3, 2024 •
edited
Loading

Repost from #30109

The issue is there are some call sites for OnTxEnd which do not pass a receipt, e.g.

go-ethereum/tests/state_test_util.go

Line 302 in 2d9d423

evm.Config.Tracer.OnTxEnd(nil, err)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

eth/tracers: avoid panic if nil-receipt passed to OnTxEnd holiman/go-ethereum
1 participant
@lightclient