Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude glacier forks from code coverage #1139

Open
SamWilsn opened this issue Mar 6, 2025 · 0 comments
Open

Exclude glacier forks from code coverage #1139

SamWilsn opened this issue Mar 6, 2025 · 0 comments
Assignees
@Carsons-Eels
Labels
A-tool Area: tooling C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers P-high
Milestone
Post-Prague Re-fa...

Comments

@SamWilsn
Copy link
Contributor

SamWilsn commented Mar 6, 2025

The *_glacier and dao_fork forks aren't tested specifically. Instead they are verified with the glacier_fork_hygiene lint.

They bring down our code coverage percentage unfairly, and so should be excluded from the report.
@SamWilsn SamWilsn added A-tool Area: tooling C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers P-high labels Mar 6, 2025
@SamWilsn SamWilsn added this to the Post-Prague Re-factoring milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Carsons-Eels Carsons-Eels

Labels
A-tool Area: tooling C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers P-high
Projects
None yet
Milestone
Post-Prague Re-factoring
Development

No branches or pull requests
2 participants
@SamWilsn @Carsons-Eels