Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to see the writings on a diagram #12150

Closed
2 tasks
aslikaya opened this issue Feb 12, 2024 · 5 comments
Closed
2 tasks

Hard to see the writings on a diagram #12150

aslikaya opened this issue Feb 12, 2024 · 5 comments
Assignees
Labels
bug 🐛 Something isn't working design system this label will be used in all issues related to design system design All the issues related to design should use this tag

Comments

@aslikaya
Copy link
Contributor

Describe the bug

When in the dark mode, reading the writings on a diagram is very hard.

To reproduce

  1. Go to https://ethereum.org/developers/docs/consensus-mechanisms/pos/attack-and-defense#reorgs
  2. Scroll down to the diagram
  3. See error

Expected behavior

It should be easily readable

Screenshots

Screenshot 2024-02-12 at 13 26 57

Desktop (please complete the following information)

MacOS, Chrome

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@aslikaya aslikaya added the bug 🐛 Something isn't working label Feb 12, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Feb 12, 2024
@iusx
Copy link
Contributor

iusx commented Mar 4, 2024

#12344 or #12345

image

image

@nhsz
Copy link
Member

nhsz commented Mar 4, 2024

@nloureiro

@nloureiro
Copy link
Contributor

@aslikaya Thank you for raising it, we are in the process of changing all diagram to a new design cohesive and system based approach.

you can see the first batch here, and ready to me merged to production

I will add this one to the priority.
Thank you.

@nloureiro nloureiro self-assigned this Mar 4, 2024
@nloureiro nloureiro added design All the issues related to design should use this tag design system this label will be used in all issues related to design system and removed needs triage 📥 This issue needs triaged before being worked on labels Mar 4, 2024
@nloureiro
Copy link
Contributor

@aslikaya I just review all the new diagrams and this one in already done

you can see here > https://deploy-preview-12233--ethereumorg.netlify.app/developers/docs/consensus-mechanisms/pos/attack-and-defense

@aslikaya
Copy link
Contributor Author

aslikaya commented Mar 5, 2024

Thanks! @nloureiro Looks good!

A few minor suggestions:

  • there are extra spaces in these two blocks between "N" and the "+" sign
Screenshot 2024-03-05 at 13 56 00
  • since slots denote time maybe showing them at the bottom might make it clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working design system this label will be used in all issues related to design system design All the issues related to design should use this tag
Projects
None yet
Development

No branches or pull requests

4 participants