Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nested topic arrays should be interpreted as match options for the topic at the nested array position #119

Closed
dylanjw opened this issue Jul 31, 2018 · 0 comments · Fixed by #118
Closed

nested topic arrays should be interpreted as match options for the topic at the nested array position #119

dylanjw opened this issue Jul 31, 2018 · 0 comments · Fixed by #118

Comments

@dylanjw
Copy link
Contributor

dylanjw commented Jul 31, 2018

  • Version:0.1.0b29
  • Python: 3.6

What was wrong?

See review comment here: https://github.com/ethereum/web3.py/pull/976/files/bec2e4e082c2ac58fd38063dec5f5a22641bc3cc

To summarize: we were interpreting the nested arrays in topic lists as full variants of the topic list, rather than options for the topic at the nested array position.

How can it be fixed?

Several methods, validators etc. need to be updated to follow the spec here:

https://github.com/ethereum/wiki/wiki/JSON-RPC#a-note-on-specifying-topic-filters
@dylanjw dylanjw changed the title nested topic arrays should be interpreted as positional match options against log topics nested topic arrays should be interpreted as match options for the topic at the nested array position Jul 31, 2018
@dylanjw dylanjw mentioned this issue Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dylanjw